kou commented on pull request #11348: URL: https://github.com/apache/arrow/pull/11348#issuecomment-938133453
> I was asking so I can learn how to test my changes better. That way future changes will require less rework. CI will detect problems like this after we implement GCS backend and its test and one or more jobs for them. > I noticed that a number of PRs to this repository are not really "merged", but "closed" and the changes appear in the `master` branch. Is that the standard practice here? Is there a rationale for it? Yes. It's the standard practice here. We use our merge tool https://github.com/apache/arrow/blob/master/dev/merge_arrow_pr.py instead of the "merge" button on Web UI. Our merge tool squashes commits, push the squashed commit with "fix #XXX" to close associated PR and update associated JIRA issue. If we use the "merge" on Web UI, we need to update associated JIRA issue manually. We want to avoid it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
