rok commented on a change in pull request #11353:
URL: https://github.com/apache/arrow/pull/11353#discussion_r724203465
##########
File path: cpp/src/arrow/compute/kernels/temporal_internal.h
##########
@@ -93,6 +103,48 @@ struct ZonedLocalizer {
local_days ConvertDays(sys_days d) const { return
local_days(year_month_day(d)); }
};
+//
+// Which types to generate a kernel for
+//
+struct WithDates {};
+struct WithTimes {};
+struct WithTimestamps {};
+
+// This helper allows generating temporal kernels for selected type categories
+// without any spurious code generation for other categories (e.g. avoid
+// generating code for date kernels for a times-only function).
+template <typename Factory>
+void AddTemporalKernels(Factory* fac) {}
Review comment:
Indeed!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
