zeroshade commented on a change in pull request #11146:
URL: https://github.com/apache/arrow/pull/11146#discussion_r725209452
##########
File path: go/parquet/internal/encoding/boolean_encoder.go
##########
@@ -47,6 +47,9 @@ func (enc *PlainBooleanEncoder) Put(in []bool) {
if enc.wr == nil {
enc.wr = utils.NewBitmapWriter(enc.bitsBuffer, 0, boolsInBuf)
}
+ if len(in) == 0 {
Review comment:
I'm not sure, it's been a really long time since I originally wrote this
code at this point, and i found it easier to do this to check for an empty or
nil input than to do this check lower since it keeps the subsequent code
cleaner by being able to assume it is non-nil and non-empty.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
