Jimexist commented on pull request #1081: URL: https://github.com/apache/arrow-datafusion/pull/1081#issuecomment-939303227
> 🤔 there seems to be a build failures but otherwise this looks good to me > > https://github.com/apache/arrow-datafusion/pull/1081/checks?check_run_id=3840276390 > > ``` > error[E0004]: non-exhaustive patterns: `&Blake2b` and `&Blake2s` not covered > --> /home/runner/work/arrow-datafusion/arrow-datafusion/datafusion/src/physical_plan/functions.rs:319:15 > | > 174 | / pub enum BuiltinScalarFunction { > 175 | | // math functions > 176 | | /// abs > 177 | | Abs, > ... | > 275 | | Blake2b, > | | ------- not covered > 276 | | /// Blake2s > 277 | | Blake2s, > | | ------- not covered > ... | > 305 | | RegexpMatch, > 306 | | } > | |_- `BuiltinScalarFunction` defined here > ... > 319 | match self { > | ^^^^ patterns `&Blake2b` and `&Blake2s` not covered > | > = help: ensure that all possible cases are being handled, possibly by adding wildcards or more match arms > = note: the matched value is of type `&BuiltinScalarFunction` > ``` > > FWIW I looked at postgres and what it does is rather than having individual functions for different hashing algorithms, it appears to have a single `digest` function that takes the requested algorithm as a string parameter > > ``` > F.26.1.1. Digest() > digest(data text, type text) returns bytea > digest(data bytea, type text) returns bytea > ``` > > https://www.postgresql.org/docs/current/pgcrypto.html let's address this in #1090 so merge that first -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
