romainfrancois commented on a change in pull request #11369:
URL: https://github.com/apache/arrow/pull/11369#discussion_r725952856
##########
File path: r/src/array_to_vector.cpp
##########
@@ -786,7 +778,7 @@ class Converter_Struct : public Converter {
private:
std::vector<std::shared_ptr<Converter>> converters;
- bool is_altrep(SEXP x) const {
+ bool is_arrow_altrep(SEXP x) const {
Review comment:
This should check that the altrep class is from this package, using e.g
`ALTREP_CLASS_SERIALIZED_CLASS` from https://github.com/apache/arrow/pull/11366
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
