alamb commented on a change in pull request #1099:
URL: https://github.com/apache/arrow-datafusion/pull/1099#discussion_r726001967
##########
File path: datafusion/src/logical_plan/expr.rs
##########
@@ -59,7 +59,7 @@ impl Column {
pub fn from_qualified_name(flat_name: &str) -> Self {
use sqlparser::tokenizer::Token;
- let dialect = sqlparser::dialect::GenericDialect {};
+ let dialect = sqlparser::dialect::PostgreSqlDialect {};
Review comment:
I would also note that the sqlparser's notion of a dialect is not super
strict -- it seems to largely concern certain parsing decisions, but even with
the dialect set to Postgres `sqlparser` will still allow through many MySQL
constructs, etc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
