kou commented on a change in pull request #11375:
URL: https://github.com/apache/arrow/pull/11375#discussion_r726673562



##########
File path: ci/docker/debian-10-cpp.dockerfile
##########
@@ -73,7 +74,10 @@ RUN apt-get update -y -q && \
 
 COPY ci/scripts/install_minio.sh \
      /arrow/ci/scripts/
+COPY ci/scripts/install_gcs_testbench.sh \
+     /arrow/ci/scripts/
 RUN /arrow/ci/scripts/install_minio.sh ${arch} linux latest /usr/local

Review comment:
       We can't reuse Docker cache with this order. We need to use the 
following order:
   
   ```suggestion
   RUN /arrow/ci/scripts/install_minio.sh ${arch} linux latest /usr/local
   COPY ci/scripts/install_gcs_testbench.sh \
        /arrow/ci/scripts/
   ```

##########
File path: ci/docker/ubuntu-20.04-cpp.dockerfile
##########
@@ -96,7 +97,10 @@ RUN apt-get update -y -q && \
 
 COPY ci/scripts/install_minio.sh \
      /arrow/ci/scripts/
+COPY ci/scripts/install_gcs_testbench.sh \
+     /arrow/ci/scripts/
 RUN /arrow/ci/scripts/install_minio.sh ${arch} linux latest /usr/local

Review comment:
       ```suggestion
   RUN /arrow/ci/scripts/install_minio.sh ${arch} linux latest /usr/local
   COPY ci/scripts/install_gcs_testbench.sh \
        /arrow/ci/scripts/
   ```

##########
File path: ci/docker/fedora-33-cpp.dockerfile
##########
@@ -64,7 +65,10 @@ RUN dnf update -y && \
 
 COPY ci/scripts/install_minio.sh \
      /arrow/ci/scripts/
+COPY ci/scripts/install_gcs_testbench.sh \
+     /arrow/ci/scripts/
 RUN /arrow/ci/scripts/install_minio.sh ${arch} linux latest /usr/local

Review comment:
       ```suggestion
   RUN /arrow/ci/scripts/install_minio.sh ${arch} linux latest /usr/local
   COPY ci/scripts/install_gcs_testbench.sh \
        /arrow/ci/scripts/
   ```

##########
File path: ci/docker/linux-apt-r.dockerfile
##########
@@ -87,7 +87,10 @@ RUN /arrow/ci/scripts/r_deps.sh /arrow
 
 COPY ci/scripts/install_minio.sh \
      /arrow/ci/scripts/
+COPY ci/scripts/install_gcs_testbench.sh \
+     /arrow/ci/scripts/
 RUN /arrow/ci/scripts/install_minio.sh ${arch} linux latest /usr/local

Review comment:
       ```suggestion
   RUN /arrow/ci/scripts/install_minio.sh ${arch} linux latest /usr/local
   COPY ci/scripts/install_gcs_testbench.sh \
        /arrow/ci/scripts/
   ```

##########
File path: ci/docker/debian-11-cpp.dockerfile
##########
@@ -71,7 +72,10 @@ RUN apt-get update -y -q && \
 
 COPY ci/scripts/install_minio.sh \
      /arrow/ci/scripts/
+COPY ci/scripts/install_gcs_testbench.sh \
+     /arrow/ci/scripts/
 RUN /arrow/ci/scripts/install_minio.sh ${arch} linux latest /usr/local

Review comment:
       ```suggestion
   RUN /arrow/ci/scripts/install_minio.sh ${arch} linux latest /usr/local
   COPY ci/scripts/install_gcs_testbench.sh \
        /arrow/ci/scripts/
   ```

##########
File path: ci/docker/ubuntu-20.10-cpp.dockerfile
##########
@@ -98,7 +99,10 @@ RUN apt-get update -y -q && \
 
 COPY ci/scripts/install_minio.sh \
      /arrow/ci/scripts/
+COPY ci/scripts/install_gcs_testbench.sh \
+     /arrow/ci/scripts/
 RUN /arrow/ci/scripts/install_minio.sh ${arch} linux latest /usr/local

Review comment:
       ```suggestion
   RUN /arrow/ci/scripts/install_minio.sh ${arch} linux latest /usr/local
   COPY ci/scripts/install_gcs_testbench.sh \
        /arrow/ci/scripts/
   ```

##########
File path: ci/docker/ubuntu-21.04-cpp.dockerfile
##########
@@ -96,7 +97,10 @@ RUN apt-get update -y -q && \
 
 COPY ci/scripts/install_minio.sh \
      /arrow/ci/scripts/
+COPY ci/scripts/install_gcs_testbench.sh \
+     /arrow/ci/scripts/
 RUN /arrow/ci/scripts/install_minio.sh ${arch} linux latest /usr/local

Review comment:
       ```suggestion
   RUN /arrow/ci/scripts/install_minio.sh ${arch} linux latest /usr/local
   COPY ci/scripts/install_gcs_testbench.sh \
        /arrow/ci/scripts/
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to