nsait-linaro commented on a change in pull request #11383:
URL: https://github.com/apache/arrow/pull/11383#discussion_r726761843
##########
File path: cpp/src/arrow/util/bit_util.h
##########
@@ -18,8 +18,11 @@
#pragma once
#if defined(_MSC_VER)
+#if defined(_M_AMD64) || defined(_M_X64)
#include <intrin.h> // IWYU pragma: keep
#include <nmmintrin.h>
+#endif
Review comment:
Yes, good question. Apparently, for clang we don't need to import any
explicit intrinsic header files they seem to be built-in functions. And MSVC
arm64 intrinsic doesn't seem to have the `__popcnt64` and `__popcnt` intrinsics
so including the intrinsics header is not required
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
