nealrichardson commented on a change in pull request #11346:
URL: https://github.com/apache/arrow/pull/11346#discussion_r727108880
##########
File path: r/R/dataset-format.R
##########
@@ -74,12 +74,12 @@ FileFormat <- R6Class("FileFormat",
type = function() dataset___FileFormat__type_name(self)
)
)
-FileFormat$create <- function(format, ...) {
+FileFormat$create <- function(format, ..., schema = NULL) {
opt_names <- names(list(...))
if (format %in% c("csv", "text") || any(opt_names %in% c("delim",
"delimiter"))) {
- CsvFileFormat$create(...)
+ CsvFileFormat$create(..., schema)
Review comment:
Right, you now need to handle the schema in csv_file_format_read_opts,
if it is not null, set the column_names
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
