nealrichardson commented on a change in pull request #11324:
URL: https://github.com/apache/arrow/pull/11324#discussion_r727366756
##########
File path: r/tests/testthat/test-schema.R
##########
@@ -38,6 +38,20 @@ test_that("Schema print method", {
)
})
+test_that("Schema with non-nullable fields", {
+ expect_output(
+ print(schema(b = double(), c = list(bool(), NULL, FALSE), d = string())),
Review comment:
I'm not a fan of the unnamed list of args, particularly with one that is
ignored. What if instead the interface supported was:
```
schema(field("b", double()), field("c", bool(), nullable = FALSE))
```
i.e. schema() accepts either a list of Fields or a named list of DataTypes
(which get turned into Fields, as it currently works)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
