nealrichardson commented on a change in pull request #11361:
URL: https://github.com/apache/arrow/pull/11361#discussion_r727641232
##########
File path: r/tests/testthat/test-metadata.R
##########
@@ -254,36 +255,62 @@ test_that("Row-level metadata (does not) roundtrip in
datasets", {
dst_dir <- make_temp_dir()
- withr::local_options(list("arrow.preserve_row_level_metadata" = TRUE))
- expect_warning(
- write_dataset(df, dst_dir, partitioning = "part"),
- "Row-level metadata is not compatible with datasets and will be discarded"
- )
+ withr::with_options(
+ list("arrow.preserve_row_level_metadata" = TRUE), {
+ withr::local_options(list("arrow.preserve_row_level_metadata" = TRUE))
Review comment:
It looks like you're setting the option twice?
##########
File path: r/.lintr
##########
@@ -22,7 +22,7 @@ linters: with_defaults(
# object_name_linter = object_name_linter(styles = c("snake_case",
"camelCase", "CamelCase", "symbols", "dotted.case", "UPPERCASE", "SNAKE_CASE")),
object_length_linter = object_length_linter(40),
object_usage_linter = NULL, # R6 methods are flagged,
- cyclocomp_linter = cyclocomp_linter(26) # TODO: reduce to default of 15
+ cyclocomp_linter = cyclocomp_linter(20) # TODO: reduce to default of 15
Review comment:
This appears to trigger a new annotation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
