houqp commented on pull request #1006:
URL: https://github.com/apache/arrow-datafusion/pull/1006#issuecomment-941938893


   Agree with @Jimexist 's comment, the rest looks good to me. @Igosuki for the 
follow up struct field access support PR, you can follow the physical plan 
evaluation implementation that @jorgecarleitao started awhile back at: 
https://github.com/apache/arrow-datafusion/pull/628/files#diff-ae63212535ac34ea66a26dc4726715b594b05794376b1b1fb511ff32211ed576R75.
 I think your SQL syntax combined with that physical plan implementation should 
be solid :+1: 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to