nealrichardson commented on a change in pull request #11405:
URL: https://github.com/apache/arrow/pull/11405#discussion_r728413222
##########
File path: r/R/arrow-datum.R
##########
@@ -232,6 +232,7 @@ is.sliceable <- function(i) {
is.numeric(i) &&
length(i) > 0 &&
all(i > 0) &&
+ i[1] <= i[length(i)] &&
Review comment:
Yeah it was on purpose, it was incorrectly determining that we could
call Slice on a sequence of `c(3, 2, 1)` to reverse the rows of the Table when
(AFAIK) we have to use Take for that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
