jonkeane commented on a change in pull request #11404:
URL: https://github.com/apache/arrow/pull/11404#discussion_r728952977
##########
File path: r/src/array_to_vector.cpp
##########
@@ -65,11 +65,14 @@ class Converter {
// converter is passed as self to outlive the scope of Converter::Convert()
SEXP ScheduleConvertTasks(RTasks& tasks, std::shared_ptr<Converter> self) {
- // try altrep first
+// try altrep first
+#if defined(HAS_ALTREP)
+ void Init_Altrep_classes(DllInfo * dll);
SEXP alt = altrep::MakeAltrepVector(chunked_array_);
Review comment:
Hmmm, these are the errors we were seeing on compilation without adding
the conditional here, is there some other way to get past these without a
conditional here?
```
array_to_vector.cpp: In member function ‘SEXPREC*
arrow::r::Converter::ScheduleConvertTasks(arrow::r::RTasks&,
std::shared_ptr<arrow::r::Converter>)’:
array_to_vector.cpp:69:16: error: ‘altrep’ has not been declared
SEXP alt = altrep::MakeAltrepVector(chunked_array_);
^~~~~~
array_to_vector.cpp: In member function ‘SEXPREC*
arrow::r::Converter::MaybeAltrep()’:
array_to_vector.cpp:124:31: error: ‘altrep’ has not been declared
SEXP MaybeAltrep() { return altrep::MakeAltrepVector(chunked_array_); }
^~~~~~
```
https://github.com/ursacomputing/crossbow/runs/3885687364?check_suite_focus=true#step:7:1423
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
