matthewmturner edited a comment on issue #1118: URL: https://github.com/apache/arrow-datafusion/issues/1118#issuecomment-944331900
@alamb happy to do this. i'll work on consolidating into `datafusion/tests/optimizer.rs` first. One quick question. By using `assert_batches_eq!` isnt that comparing the final record batch output? And couldnt you have that same output regardless of whether an optimization was used? Or was the idea to just add that as an additional assertion? UPDATE I've had the chance to review more of the provided references (thanks for that). I'm thinking it may be better if I work on #743 first to get the right structure in place (and get myself familiar with the testing approach) and then add `optimizers.rs` to the tests. Let me know if any thoughts. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
