kszucs commented on a change in pull request #11433:
URL: https://github.com/apache/arrow/pull/11433#discussion_r729852835
##########
File path: dev/tasks/python-wheels/github.osx.arm64.yml
##########
@@ -25,7 +25,6 @@
env:
ARROW_FLIGHT: OFF
ARROW_JEMALLOC: OFF
- ARROW_SIMD_LEVEL: NONE
Review comment:
Use the default `SSE4_2` set in the [macos build
script](https://github.com/apache/arrow/blob/master/ci/scripts/python_wheel_macos_build.sh#L74)
which [should
enable](https://github.com/apache/arrow/blob/master/cpp/cmake_modules/SetupCxxFlags.cmake#L444)
`ARROW_HAVE_NEON`.
@pitrou could we define a `MAX` default value for
[ARROW_SIMD_LEVEL](https://github.com/apache/arrow/blob/master/cpp/cmake_modules/DefineOptions.cmake#L115)
and possibly add `NEON` to the list of options?
##########
File path: dev/tasks/python-wheels/github.osx.arm64.yml
##########
@@ -25,7 +25,6 @@
env:
ARROW_FLIGHT: OFF
ARROW_JEMALLOC: OFF
- ARROW_SIMD_LEVEL: NONE
Review comment:
Use the default `SSE4_2` set in the [macos build
script](https://github.com/apache/arrow/blob/master/ci/scripts/python_wheel_macos_build.sh#L74)
which [should
enable](https://github.com/apache/arrow/blob/master/cpp/cmake_modules/SetupCxxFlags.cmake#L444)
`ARROW_HAVE_NEON`.
@pitrou could we define (in a follow-up for the next release) a `MAX`
default value for
[ARROW_SIMD_LEVEL](https://github.com/apache/arrow/blob/master/cpp/cmake_modules/DefineOptions.cmake#L115)
and possibly add `NEON` to the list of options?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
