kou commented on a change in pull request #11399:
URL: https://github.com/apache/arrow/pull/11399#discussion_r730497854
##########
File path: cpp/examples/parquet/parquet_stream_api/stream_reader_writer.cc
##########
@@ -136,12 +137,14 @@ struct TestData {
return "Str #" + std::to_string(i);
}
static arrow::util::string_view GetStringView(const int i) {
- string_ = "StringView #" + std::to_string(i);
+ int length = snprintf(string_, str_buff_size, "StringView #%d", i);
+ snprintf(string_, length + 1, "StringView #%d", i);
return arrow::util::string_view(string_);
Review comment:
How about this?
```c++
static std::string string;
string = "StringView #" + std::to_string(i);
return arrow::util::string_view(string);
```
##########
File path: docker-compose.yml
##########
@@ -1065,9 +1065,26 @@ services:
/arrow/ci/scripts/r_test.sh /arrow"
ubuntu-r-only-r:
+ image: ${REPO}:${ARCH}-ubuntu-${UBUNTU}-r-${R}
+ build:
+ context: .
+ dockerfile: ci/docker/linux-apt-r.dockerfile
+ cache_from:
+ - ${REPO}:${ARCH}-ubuntu-${UBUNTU}-r-${R}
+ args:
+ arch: ${ARCH}
+ r: ${R}
+ base: ${REPO}:${ARCH}-ubuntu-${UBUNTU}-cpp
+ gcc_version: ${GCC_VERSION}
+ tz: ${TZ}
+ shm_size: *shm-size
environment:
- ARROW_DEPENDENCY_SOURCE: ''
- extends: ubuntu-r
+ <<: *ccache
+ ARROW_R_CXXFLAGS: '-Werror'
+ LIBARROW_BUILD: 'false'
+ NOT_CRAN: 'true'
+ ARROW_R_DEV: ${ARROW_R_DEV}
+ volumes: *ubuntu-volumes
Review comment:
Should we include this change into this pull request?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
