Jimexist commented on a change in pull request #984:
URL: https://github.com/apache/arrow-datafusion/pull/984#discussion_r730614682



##########
File path: datafusion/src/physical_plan/sort_preserving_merge.rs
##########
@@ -1156,10 +1156,24 @@ mod tests {
     #[tokio::test]
     async fn test_async() {
         let schema = test::aggr_test_schema();
-        let sort = vec![PhysicalSortExpr {
-            expr: col("c7", &schema).unwrap(),
-            options: SortOptions::default(),
-        }];
+        let sort = vec![

Review comment:
       do we need to add a stable sort option in arrow sort kernel?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to