alamb commented on a change in pull request #984:
URL: https://github.com/apache/arrow-datafusion/pull/984#discussion_r731203286
##########
File path: datafusion/src/physical_plan/sort_preserving_merge.rs
##########
@@ -1156,10 +1156,24 @@ mod tests {
#[tokio::test]
async fn test_async() {
let schema = test::aggr_test_schema();
- let sort = vec![PhysicalSortExpr {
- expr: col("c7", &schema).unwrap(),
- options: SortOptions::default(),
- }];
+ let sort = vec![
Review comment:
I am not sure @Jimexist -- I think it is fairly common that analytic
systems don't really have the notion of "stable" sort (because the data doesn't
have any well defined sort order in storage).
In DataFusion, for example, the order that the rows are produced (and how
they are partitioned) depends on the DataSource (as well as they may be
re-arranged by a repartition / coalesce operator). This stable sorting really
only is useful for testing when the output has a single `RecordBatch` I think
It may be best not to get used to / rely on that stable sorting
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
