lidavidm commented on a change in pull request #11408:
URL: https://github.com/apache/arrow/pull/11408#discussion_r731291823
##########
File path: python/pyarrow/tests/test_fs.py
##########
@@ -348,6 +349,23 @@ def _wait_for_minio_startup(mcdir, address, access_key,
secret_key):
raise Exception("mc command could not connect to local minio")
+def _ensure_minio_component_version(component, minimum_year):
+ full_args = [component, '--version']
+ proc = subprocess.Popen(full_args, stdout=subprocess.PIPE,
+ stderr=subprocess.PIPE, encoding='utf-8')
+ retval = proc.wait(10)
+ if (retval != 0):
Review comment:
```suggestion
if proc.wait(10) != 0:
```
##########
File path: python/pyarrow/tests/test_fs.py
##########
@@ -348,6 +349,23 @@ def _wait_for_minio_startup(mcdir, address, access_key,
secret_key):
raise Exception("mc command could not connect to local minio")
+def _ensure_minio_component_version(component, minimum_year):
+ full_args = [component, '--version']
+ proc = subprocess.Popen(full_args, stdout=subprocess.PIPE,
+ stderr=subprocess.PIPE, encoding='utf-8')
+ retval = proc.wait(10)
+ if (retval != 0):
Review comment:
Just a small style nit (or we could keep retval as a separate variable)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
