kou commented on a change in pull request #11448:
URL: https://github.com/apache/arrow/pull/11448#discussion_r731290973



##########
File path: cpp/Brewfile
##########
@@ -25,7 +25,7 @@ brew "flatbuffers"
 brew "git"
 brew "glog"
 brew "grpc"
-brew "llvm@12"
+brew "llvm@13"

Review comment:
       Could you use no versioned `"llvm"` to use the last LLVM in CI?
   
   ```suggestion
   brew "llvm"
   ```

##########
File path: .github/workflows/cpp.yml
##########
@@ -252,7 +252,7 @@ jobs:
       ARROW_BUILD_TYPE: release
       ARROW_DATASET: ON
       ARROW_FLIGHT: ON
-      ARROW_GANDIVA: ON
+      ARROW_GANDIVA: OFF

Review comment:
       I reported this to upstream: 
https://github.com/msys2/MINGW-packages/issues/9801
   
   Could you mention it here?
   
   ```suggestion
         # We can enable this again once 
https://github.com/msys2/MINGW-packages/issues/9801 is fixed.
         ARROW_GANDIVA: OFF
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to