Dandandan commented on a change in pull request #1146:
URL: https://github.com/apache/arrow-datafusion/pull/1146#discussion_r731653948
##########
File path: datafusion/src/optimizer/common_subexpr_eliminate.rs
##########
@@ -75,6 +75,17 @@ impl CommonSubexprEliminate {
fn optimize(plan: &LogicalPlan, execution_props: &ExecutionProps) ->
Result<LogicalPlan> {
let mut expr_set = ExprSet::new();
+ let mut to_arrays = |expr: &[Expr], input: &LogicalPlan| {
Review comment:
Could you extract this to a `fn` instead of inline closure?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
