bkietz commented on a change in pull request #11439:
URL: https://github.com/apache/arrow/pull/11439#discussion_r731969831



##########
File path: experimental/computeir/Relation.fbs
##########
@@ -197,6 +197,13 @@ table LiteralRelation {
 table Source {
   base: RelBase (required);
   name: string (required);
+  /// An optional list of field indices indicating which columns should be read
+  /// from the source.

Review comment:
       I think in this instance it's useful to be explicit that subsequent 
field references point into the source's original schema regardless of 
`projection` rather than needing to double dereference
   ```suggestion
     /// An optional list of field indices indicating which columns should be 
read
     /// from the source. Columns excluded from this listing will instead be 
replaced
     /// with all-null placeholders to guarantee that the schema of the source 
is
     /// unaffected by this projection.
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to