jonmmease commented on a change in pull request #1142:
URL: https://github.com/apache/arrow-datafusion/pull/1142#discussion_r732564198
##########
File path: datafusion/src/scalar.rs
##########
@@ -945,7 +1018,15 @@ impl ScalarValue {
&DataType::LargeUtf8 => {
build_list!(LargeStringBuilder, LargeUtf8, values, size)
}
- dt => panic!("Unexpected DataType for list {:?}", dt),
+ _ => ScalarValue::iter_to_array_list(
Review comment:
My intuition was that the current specialized implementations would be
more efficient, but I didn't actually benchmark that assumption.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
