jorisvandenbossche commented on a change in pull request #11481:
URL: https://github.com/apache/arrow/pull/11481#discussion_r733629480
##########
File path: cpp/src/arrow/python/numpy_to_arrow.cc
##########
@@ -268,6 +270,7 @@ class NumPyConverter {
if (mask_ != nullptr) {
RETURN_NOT_OK(InitNullBitmap());
null_count_ = MaskToBitmap(mask_, length_, null_bitmap_data_);
+ if (null_count_ == -1) return Status::Invalid("Invalid mask type");
Review comment:
I suppose this isn't actually covered at the moment, since we convert
the input to an ndarray first (after the regression fix). But can be useful to
keep if we make a similar mistake in the future? (to avoid segfaults in such a
case?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
