rdettai commented on a change in pull request #1063:
URL: https://github.com/apache/arrow-datafusion/pull/1063#discussion_r733751214
##########
File path: datafusion/src/physical_optimizer/aggregate_statistics.rs
##########
@@ -311,6 +372,33 @@ mod tests {
Ok(())
}
+ #[tokio::test]
+ async fn test_count_partial_with_nulls_direct_child() -> Result<()> {
Review comment:
this is not testing the code that you have added, it tests that
`take_optimizable_count` also works if there are nulls in the source dataset.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
