yahoNanJing commented on a change in pull request #1062: URL: https://github.com/apache/arrow-datafusion/pull/1062#discussion_r733782561
########## File path: datafusion/src/datasource/object_store/hdfs/os_parquet.rs ########## @@ -0,0 +1,102 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +//! Parquet related things for hdfs object store +use std::io::{Read, Seek, SeekFrom}; +use std::sync::Arc; + +use parquet::file::reader::{ChunkReader, Length}; +use parquet::util::io::{FileSource, TryClone}; + +use crate::datasource::object_store::hdfs::{to_error, HadoopFileSystem}; +use crate::datasource::object_store::ObjectReader; +use crate::datasource::parquet::dynamic_reader::{DynChunkReader, DynRead}; + +use super::HadoopFile; +use crate::error::Result; + +/// Parquet file reader for hdfs object store, by which we can get ``DynChunkReader`` +#[derive(Clone)] +pub struct HadoopParquetFileReader { Review comment: > Thank you for this PR @yahoNanJing -- this is a great start. I haven't reviewed the code carefully, but the basic idea looks wonderful to me > > How do you think we should proceed with parallel implementations with #1010 ? It seems like the actual hdfs bindings / object store implementation for hdfs are valuable, but the changes to the parquet reader are likely going to conflict Thanks @alamb and @houqp for your comments. I'll do a refactoring based on the latest code merged with #1010. Sorry for the late reply since I'm asked to deal with other things😂 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
