lidavidm commented on a change in pull request #11507: URL: https://github.com/apache/arrow/pull/11507#discussion_r734745096
########## File path: cpp/src/arrow/flight/flight-sql/client.h ########## @@ -0,0 +1,260 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#ifndef ARROW_FLIGHT_SQL_CLIENT_H +#define ARROW_FLIGHT_SQL_CLIENT_H + +#include <arrow/flight/Flight.pb.h> +#include <arrow/flight/client.h> +#include <arrow/flight/flight-sql/FlightSql.pb.h> +#include <arrow/flight/types.h> +#include <arrow/status.h> +#include <google/protobuf/message.h> + +namespace pb = arrow::flight::protocol; + +namespace arrow { +namespace flight { +namespace sql { +namespace internal { + +template <class T = arrow::flight::FlightClient> +class ARROW_EXPORT PreparedStatementT { Review comment: You could also have this structure, I think: - client.h has an abstract base class and a function `MakePreparedStatement()` - client_internal.h has: ```cpp template <class T> class PreparedStatementImpl : public PreparedStatement { // ...current impl... }; ``` - In tests, include client_internal.h and instantiate `PreparedStatementImpl<MockClient>` - In client.cc, include client_internal.h and instantiate `PreparedStatementImpl<FlightClient>` to implement `MakePreparedStatement` (maybe a MakePreparedStatementImpl also needs to be templated and in client_internal.h) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
