Jimexist commented on a change in pull request #1165: URL: https://github.com/apache/arrow-datafusion/pull/1165#discussion_r734960961
########## File path: datafusion/src/physical_plan/values.rs ########## @@ -0,0 +1,168 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +//! Values execution plan + +use super::{common, SendableRecordBatchStream, Statistics}; +use crate::error::{DataFusionError, Result}; +use crate::physical_plan::{ + memory::MemoryStream, ColumnarValue, DisplayFormatType, Distribution, ExecutionPlan, + Partitioning, PhysicalExpr, +}; +use crate::scalar::ScalarValue; +use arrow::datatypes::SchemaRef; +use arrow::record_batch::RecordBatch; +use async_trait::async_trait; +use std::any::Any; +use std::sync::Arc; + +/// Execution plan for values list based relation (produces constant rows) +#[derive(Debug)] +pub struct ValuesExec { + /// The schema + schema: SchemaRef, + /// The data + data: Vec<RecordBatch>, +} + +impl ValuesExec { + /// create a new values exec from data as expr + pub fn try_new( + schema: SchemaRef, + data: Vec<Vec<Arc<dyn PhysicalExpr>>>, + ) -> Result<Self> { + if data.is_empty() { + return Err(DataFusionError::Plan("Values list cannot be empty".into())); + } + // we have this empty batch as a placeholder to satisfy evaluation argument Review comment: i can address this in a subsequent PR where more expr types are supported (e.g. `CAST`) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
