lidavidm commented on a change in pull request #11495:
URL: https://github.com/apache/arrow/pull/11495#discussion_r735746077
##########
File path: cpp/src/arrow/scalar.h
##########
@@ -342,7 +342,7 @@ struct ARROW_EXPORT TimestampScalar : public
TemporalScalar<TimestampType> {
};
template <typename T>
-struct ARROW_EXPORT IntervalScalar : public TemporalScalar<T> {
Review comment:
Hmm, why is it only these particular classes that can't be exported? For
instance, why don't we need to remove `ARROW_EXPORT` from `TimeScalar` (which
is also a base class like the rest of these)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
