alamb opened a new pull request #1176:
URL: https://github.com/apache/arrow-datafusion/pull/1176
# Which issue does this PR close?
Resolves https://github.com/apache/arrow-datafusion/issues/1175
# Rationale for this change
This is a follow on suggestion from @rdettai on
https://github.com/apache/arrow-datafusion/pull/1153
https://github.com/apache/arrow-datafusion/pull/1153/files#r735437280
Namely the substitution of `now()` for the current value is better described
as "constant evaluation" rather than "algebraic simplification" so it should be
done in the `ConstEvaluator` code.
It also has the very nice property that expressions that include `now()` can
also be more completely evaluated (will comment inline)
# What changes are included in this PR?
1. Move code to fold Stable functions like `now()` from `Simplifier()` to
`ConstEvaluator`
2. Fix code that did not apply const evaluator to filter predicates
# Are there any user-facing changes?
MOAR constant folding!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
