projjal commented on a change in pull request #11193:
URL: https://github.com/apache/arrow/pull/11193#discussion_r736267605
##########
File path: cpp/src/gandiva/gandiva_object_cache.h
##########
@@ -71,8 +71,10 @@ class GandivaObjectCache : public llvm::ObjectCache {
if (cached_obj != nullptr) {
std::unique_ptr<llvm::MemoryBuffer> cached_buffer =
cached_obj->getMemBufferCopy(
cached_obj->getBuffer(), cached_obj->getBufferIdentifier());
+ ARROW_LOG(INFO) << "[INFO][CACHE-LOG]: An object code was found on
cache.";
Review comment:
You shouldn't LOG in header files. Better to move it out to .cc file
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
