lidavidm commented on pull request #11507:
URL: https://github.com/apache/arrow/pull/11507#issuecomment-952157564
Alright, I got a fully statically linked build and can't reproduce the
Protobuf issue, with this diff:
```diff
diff --git a/cpp/src/arrow/flight/flight-sql/CMakeLists.txt
b/cpp/src/arrow/flight/flight-sql/CMakeLists.txt
index 7491896fe..f4b6a0546 100644
--- a/cpp/src/arrow/flight/flight-sql/CMakeLists.txt
+++ b/cpp/src/arrow/flight/flight-sql/CMakeLists.txt
@@ -36,7 +36,7 @@
set_source_files_properties(${FLIGHT_SQL_GENERATED_PROTO_FILES} PROPERTIES GENER
add_custom_target(flight_sql_protobuf_gen ALL DEPENDS
${FLIGHT_SQL_GENERATED_PROTO_FILES})
-set(ARROW_FLIGHT_SQL_SRCS server.cc)
+set(ARROW_FLIGHT_SQL_SRCS server.cc
"${CMAKE_CURRENT_BINARY_DIR}/FlightSql.pb.cc")
add_arrow_lib(arrow_flight_sql
CMAKE_PACKAGE_NAME
@@ -69,8 +69,7 @@ else()
${ARROW_TEST_LINK_LIBS})
endif()
-add_executable(flight_sql_test_app test_app_cli.cc
-
${CMAKE_CURRENT_BINARY_DIR}/FlightSql.pb.cc)
+add_executable(flight_sql_test_app test_app_cli.cc)
target_link_libraries(flight_sql_test_app PRIVATE arrow_flight_sql_static
${GFLAGS_LIBRARIES})
@@ -78,7 +77,6 @@ add_arrow_test(flight_sql_test
SOURCES
client_test.cc
server_test.cc
- "${CMAKE_CURRENT_BINARY_DIR}/FlightSql.pb.cc"
STATIC_LINK_LIBS
${ARROW_FLIGHT_SQL_TEST_LINK_LIBS}
LABELS
@@ -95,8 +93,7 @@ if(ARROW_BUILD_TESTS OR ARROW_BUILD_EXAMPLES)
example/sqlite_statement.cc
example/sqlite_statement_batch_reader.cc
example/sqlite_server.cc
- example/sqlite_tables_schema_batch_reader.cpp
- "${CMAKE_CURRENT_BINARY_DIR}/FlightSql.pb.cc")
+ example/sqlite_tables_schema_batch_reader.cpp)
target_link_libraries(flight_sql_test_server
PRIVATE arrow_flight_sql_static ${GFLAGS_LIBRARIES}
${SQLite3_LIBRARIES})
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
