nealrichardson commented on a change in pull request #11552:
URL: https://github.com/apache/arrow/pull/11552#discussion_r737014209
##########
File path: r/R/dataset-write.R
##########
@@ -97,6 +97,7 @@ write_dataset <- function(dataset,
partitioning = dplyr::group_vars(dataset),
basename_template = paste0("part-{i}.",
as.character(format)),
hive_style = TRUE,
+ existing_data_behavior = c("overwrite", "error",
"delete_matching"),
Review comment:
When we add a function argument, we also have to add a `@param` in the
docstrings above (around L40) for it, then regenerate the docs.
Side observation: I don't love the param name or even the behavior of
"overwrite" (why not always add files instead of sometimes overwriting,
particularly when the names of the files being generated isn't totally
deterministic/depends on other parameters and the data?) or "delete_matching"
(which I don't understand the rationale for). I would expect a more pure
`append = TRUE/FALSE` behavior. But that's clearly not in scope here and this
is fine; we can discuss later/elsewhere.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
