jorisvandenbossche commented on a change in pull request #11479:
URL: https://github.com/apache/arrow/pull/11479#discussion_r737303879
##########
File path: docs/source/python/getstarted.rst
##########
@@ -80,6 +80,13 @@ data will be as quick as possible
reloaded_birthdays
+.. ipython:: python
+ :suppress:
+
+ import os
+
+ os.remove("birthdays.parquet")
Review comment:
Personally I would prefer to have it also after it, so it "cleans up"
after building, so you don't constantly have files lingering around (which
could of course be solved by adding them to gitignore, but that's a bit of
duplication).
Now, it's true that if you have for some reason those files laying around
and if that gives an error, that's really annoying (and removing it beforehand
would solve that). But it should also be quite rare that it gets interrupted or
crashes exactly here.
BTW, for this file it actually doesn't error if it already exists. Removing
this one is just for cleaning up in general (and so this addition in specific
is not crucial to get the doc building working when doing it multiple times).
It's only for the `savedir` below that it gives error if already existing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
