alamb commented on a change in pull request #1183:
URL: https://github.com/apache/arrow-datafusion/pull/1183#discussion_r737918077
##########
File path: datafusion/src/execution/dataframe_impl.rs
##########
@@ -56,8 +56,12 @@ impl DataFrameImpl {
/// Create a physical plan
async fn create_physical_plan(&self) -> Result<Arc<dyn ExecutionPlan>> {
let state = self.ctx_state.lock().unwrap().clone();
+ let has_optimized = state.has_optimized;
Review comment:
I think it is ok to call `DataFrame::create_physical_plan()` twice on
the same DataFrame -- with this implementation, won't the second call to
`create_physical_plan` not be optimized?
I vaguely remember @Dandandan finding something similar in the past, but I
can't find the reference
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
