kou commented on a change in pull request #11562:
URL: https://github.com/apache/arrow/pull/11562#discussion_r737949786
##########
File path: dev/release/VERIFY.md
##########
@@ -26,9 +26,9 @@ Windows. Read the comments in `verify-release-candidate.bat`
for instructions.
## Linux and macOS
-We've provided a convenience script for verifying the C++, Python, C
-GLib, Java and JavaScript builds on Linux and macOS. Read the comments in
-`verify-release-candidate.sh` for instructions.
+We've provided a convenience script for verifying the C++, Python, C GLib,
+Java, Ruby, Go and JavaScript builds on Linux and macOS. Read the script
Review comment:
C# is missing.
##########
File path: dev/release/VERIFY.md
##########
@@ -74,3 +74,98 @@ You need to set `PKG_CONFIG_PATH` to find libffi on macOS:
```console
% export PKG_CONFIG_PATH=$(brew --prefix libffi)/lib/pkgconfig:$PKG_CONFIG_PATH
```
+
+### Dependencies for C++, C Glib, GO, Javascript, Python, Ruby
+
+Possible setups to be able to run the verification script that
+can be adapted to different situations. GO and Javascript are
+installed by the script in the testing environment.
+
+By default the script will try to verify all implementations and
+bindings. Should one of them fail, it can be helpful to repeat
+the failed test and run the tests which have not been completed.
+This can be done by setting environment variables, for example
+```console
Review comment:
```suggestion
```console
```
##########
File path: dev/release/VERIFY.md
##########
@@ -74,3 +74,98 @@ You need to set `PKG_CONFIG_PATH` to find libffi on macOS:
```console
% export PKG_CONFIG_PATH=$(brew --prefix libffi)/lib/pkgconfig:$PKG_CONFIG_PATH
```
+
+### Dependencies for C++, C Glib, GO, Javascript, Python, Ruby
Review comment:
```suggestion
### Dependencies for C++, C#, C GLib, Go, JavaScript, Python, Ruby
```
I'm not sure that this title is good for the following sentences...
##########
File path: dev/release/VERIFY.md
##########
@@ -74,3 +74,98 @@ You need to set `PKG_CONFIG_PATH` to find libffi on macOS:
```console
% export PKG_CONFIG_PATH=$(brew --prefix libffi)/lib/pkgconfig:$PKG_CONFIG_PATH
```
+
+### Dependencies for C++, C Glib, GO, Javascript, Python, Ruby
+
+Possible setups to be able to run the verification script that
+can be adapted to different situations. GO and Javascript are
+installed by the script in the testing environment.
+
+By default the script will try to verify all implementations and
+bindings. Should one of them fail, it can be helpful to repeat
+the failed test and run the tests which have not been completed.
+This can be done by setting environment variables, for example
+```console
+% env "TEST_DEFAULT=0" env "TEST_GO=1" bash
dev/release/verify-release-candidate.sh source 6.0.0 3
+```
+
+##### Ubuntu 20.04
Review comment:
Do you want to describe how to setup environments to run verification
script?
If so, how about creating a setup script something like
`dev/release/setup.sh` instead of writing command lines? It may be able to use
`dev/tasks/verify-rc/github.linux.amd64.yml`.
##########
File path: dev/release/VERIFY.md
##########
@@ -74,3 +74,98 @@ You need to set `PKG_CONFIG_PATH` to find libffi on macOS:
```console
% export PKG_CONFIG_PATH=$(brew --prefix libffi)/lib/pkgconfig:$PKG_CONFIG_PATH
```
+
+### Dependencies for C++, C Glib, GO, Javascript, Python, Ruby
+
+Possible setups to be able to run the verification script that
+can be adapted to different situations. GO and Javascript are
+installed by the script in the testing environment.
+
+By default the script will try to verify all implementations and
+bindings. Should one of them fail, it can be helpful to repeat
+the failed test and run the tests which have not been completed.
+This can be done by setting environment variables, for example
+```console
+% env "TEST_DEFAULT=0" env "TEST_GO=1" bash
dev/release/verify-release-candidate.sh source 6.0.0 3
Review comment:
```suggestion
% TEST_DEFAULT=0 TEST_GO=1 dev/release/verify-release-candidate.sh source
6.0.0 3
```
##########
File path: dev/release/VERIFY.md
##########
@@ -74,3 +74,98 @@ You need to set `PKG_CONFIG_PATH` to find libffi on macOS:
```console
% export PKG_CONFIG_PATH=$(brew --prefix libffi)/lib/pkgconfig:$PKG_CONFIG_PATH
```
+
+### Dependencies for C++, C Glib, GO, Javascript, Python, Ruby
+
+Possible setups to be able to run the verification script that
+can be adapted to different situations. GO and Javascript are
+installed by the script in the testing environment.
+
+By default the script will try to verify all implementations and
+bindings. Should one of them fail, it can be helpful to repeat
+the failed test and run the tests which have not been completed.
+This can be done by setting environment variables, for example
+```console
+% env "TEST_DEFAULT=0" env "TEST_GO=1" bash
dev/release/verify-release-candidate.sh source 6.0.0 3
+```
+
+##### Ubuntu 20.04
+
+Possible steps run as root user. They should be modified for
+your setup appropriately.
+
+```console
+% apt-get update
+% apt-get install -y cmake wget curl libboost-all-dev jq unzip
+% apt-get install -y -q autoconf-archive gtk-doc-tools libgirepository1.0-dev
+% apt-get update -y -qq
+% apt-get install -y build-essential openjdk-8-jdk
+% wget
https://dlcdn.apache.org/maven/maven-3/3.8.3/binaries/apache-maven-3.8.3-bin.zip
Review comment:
Why don't you install `maven` package instead of building Maven?
##########
File path: dev/release/VERIFY.md
##########
@@ -74,3 +74,98 @@ You need to set `PKG_CONFIG_PATH` to find libffi on macOS:
```console
% export PKG_CONFIG_PATH=$(brew --prefix libffi)/lib/pkgconfig:$PKG_CONFIG_PATH
```
+
+### Dependencies for C++, C Glib, GO, Javascript, Python, Ruby
+
+Possible setups to be able to run the verification script that
+can be adapted to different situations. GO and Javascript are
+installed by the script in the testing environment.
+
+By default the script will try to verify all implementations and
+bindings. Should one of them fail, it can be helpful to repeat
+the failed test and run the tests which have not been completed.
+This can be done by setting environment variables, for example
+```console
+% env "TEST_DEFAULT=0" env "TEST_GO=1" bash
dev/release/verify-release-candidate.sh source 6.0.0 3
+```
+
+##### Ubuntu 20.04
+
+Possible steps run as root user. They should be modified for
+your setup appropriately.
+
+```console
+% apt-get update
+% apt-get install -y cmake wget curl libboost-all-dev jq unzip
+% apt-get install -y -q autoconf-archive gtk-doc-tools libgirepository1.0-dev
+% apt-get update -y -qq
+% apt-get install -y build-essential openjdk-8-jdk
+% wget
https://dlcdn.apache.org/maven/maven-3/3.8.3/binaries/apache-maven-3.8.3-bin.zip
+% unzip apache-maven-3.8.3-bin.zip
+% mkdir -p $HOME/java
+% mv apache-maven-3.8.3 $HOME/java
+% export PATH=$HOME/java/apache-maven-3.8.3/bin:$PATH
+% apt-get install -y curl g++ gcc autoconf automake bison libc6-dev libffi-dev
+% apt-get install -y libgdbm-dev libncurses5-dev libsqlite3-dev libtool
libyaml-dev
+% apt-get install -y make pkg-config sqlite3 zlib1g-dev libgmp-dev
+% apt-get install -y libreadline-dev libssl-dev
+% wget https://cache.ruby-lang.org/pub/ruby/3.0/ruby-3.0.2.tar.gz
+% tar -xvf ruby-3.0.2.tar.gz
+% cd ruby-3.0.2/
+% CC=gcc ./configure --prefix=$HOME/ruby
+% CC=gcc make
+% make install
+% cd ..
+% export PATH=$HOME/ruby/bin:$PATH
+% wget https://apt.llvm.org/llvm.sh
Review comment:
We can use system LLVM related packages.
##########
File path: dev/release/VERIFY.md
##########
@@ -74,3 +74,98 @@ You need to set `PKG_CONFIG_PATH` to find libffi on macOS:
```console
% export PKG_CONFIG_PATH=$(brew --prefix libffi)/lib/pkgconfig:$PKG_CONFIG_PATH
```
+
+### Dependencies for C++, C Glib, GO, Javascript, Python, Ruby
+
+Possible setups to be able to run the verification script that
+can be adapted to different situations. GO and Javascript are
+installed by the script in the testing environment.
+
+By default the script will try to verify all implementations and
+bindings. Should one of them fail, it can be helpful to repeat
+the failed test and run the tests which have not been completed.
+This can be done by setting environment variables, for example
+```console
+% env "TEST_DEFAULT=0" env "TEST_GO=1" bash
dev/release/verify-release-candidate.sh source 6.0.0 3
+```
+
+##### Ubuntu 20.04
+
+Possible steps run as root user. They should be modified for
+your setup appropriately.
+
+```console
+% apt-get update
+% apt-get install -y cmake wget curl libboost-all-dev jq unzip
+% apt-get install -y -q autoconf-archive gtk-doc-tools libgirepository1.0-dev
+% apt-get update -y -qq
+% apt-get install -y build-essential openjdk-8-jdk
+% wget
https://dlcdn.apache.org/maven/maven-3/3.8.3/binaries/apache-maven-3.8.3-bin.zip
+% unzip apache-maven-3.8.3-bin.zip
+% mkdir -p $HOME/java
+% mv apache-maven-3.8.3 $HOME/java
+% export PATH=$HOME/java/apache-maven-3.8.3/bin:$PATH
+% apt-get install -y curl g++ gcc autoconf automake bison libc6-dev libffi-dev
+% apt-get install -y libgdbm-dev libncurses5-dev libsqlite3-dev libtool
libyaml-dev
+% apt-get install -y make pkg-config sqlite3 zlib1g-dev libgmp-dev
+% apt-get install -y libreadline-dev libssl-dev
+% wget https://cache.ruby-lang.org/pub/ruby/3.0/ruby-3.0.2.tar.gz
+% tar -xvf ruby-3.0.2.tar.gz
+% cd ruby-3.0.2/
+% CC=gcc ./configure --prefix=$HOME/ruby
+% CC=gcc make
+% make install
+% cd ..
+% export PATH=$HOME/ruby/bin:$PATH
+% wget https://apt.llvm.org/llvm.sh
+% chmod +x llvm.sh
+% ./llvm.sh 10
+% apt-get install -y clang-format clang-tidy clang-tools clang clangd
libc++-dev
+% apt-get install -y libc++1 libc++abi-dev libc++abi1 libclang-dev libclang1
+% apt-get install -y liblldb-dev libllvm-ocaml-dev libomp-dev libomp5 lld lldb
+% apt-get install -y llvm-dev llvm-runtime llvm python-clang
+% apt-get install -y ninja-build python3-pip
+% curl -fsSL https://download.docker.com/linux/ubuntu/gpg | sudo gpg --dearmor
-o /usr/share/keyrings/docker-archive-keyring.gpg
Review comment:
Why do you install Docker?
`verify-release-candidate.sh source` doesn't use Docker.
`verify-release-candidate.sh binaries` only uses Docker.
##########
File path: dev/release/VERIFY.md
##########
@@ -74,3 +74,98 @@ You need to set `PKG_CONFIG_PATH` to find libffi on macOS:
```console
% export PKG_CONFIG_PATH=$(brew --prefix libffi)/lib/pkgconfig:$PKG_CONFIG_PATH
```
+
+### Dependencies for C++, C Glib, GO, Javascript, Python, Ruby
+
+Possible setups to be able to run the verification script that
+can be adapted to different situations. GO and Javascript are
+installed by the script in the testing environment.
+
+By default the script will try to verify all implementations and
+bindings. Should one of them fail, it can be helpful to repeat
+the failed test and run the tests which have not been completed.
+This can be done by setting environment variables, for example
+```console
+% env "TEST_DEFAULT=0" env "TEST_GO=1" bash
dev/release/verify-release-candidate.sh source 6.0.0 3
+```
+
+##### Ubuntu 20.04
+
+Possible steps run as root user. They should be modified for
+your setup appropriately.
+
+```console
+% apt-get update
+% apt-get install -y cmake wget curl libboost-all-dev jq unzip
+% apt-get install -y -q autoconf-archive gtk-doc-tools libgirepository1.0-dev
+% apt-get update -y -qq
+% apt-get install -y build-essential openjdk-8-jdk
+% wget
https://dlcdn.apache.org/maven/maven-3/3.8.3/binaries/apache-maven-3.8.3-bin.zip
+% unzip apache-maven-3.8.3-bin.zip
+% mkdir -p $HOME/java
+% mv apache-maven-3.8.3 $HOME/java
+% export PATH=$HOME/java/apache-maven-3.8.3/bin:$PATH
+% apt-get install -y curl g++ gcc autoconf automake bison libc6-dev libffi-dev
+% apt-get install -y libgdbm-dev libncurses5-dev libsqlite3-dev libtool
libyaml-dev
+% apt-get install -y make pkg-config sqlite3 zlib1g-dev libgmp-dev
+% apt-get install -y libreadline-dev libssl-dev
+% wget https://cache.ruby-lang.org/pub/ruby/3.0/ruby-3.0.2.tar.gz
Review comment:
Why don't you install `ruby-dev` package instead of building Ruby?
##########
File path: dev/release/VERIFY.md
##########
@@ -74,3 +74,98 @@ You need to set `PKG_CONFIG_PATH` to find libffi on macOS:
```console
% export PKG_CONFIG_PATH=$(brew --prefix libffi)/lib/pkgconfig:$PKG_CONFIG_PATH
```
+
+### Dependencies for C++, C Glib, GO, Javascript, Python, Ruby
+
+Possible setups to be able to run the verification script that
+can be adapted to different situations. GO and Javascript are
+installed by the script in the testing environment.
+
+By default the script will try to verify all implementations and
+bindings. Should one of them fail, it can be helpful to repeat
+the failed test and run the tests which have not been completed.
+This can be done by setting environment variables, for example
+```console
+% env "TEST_DEFAULT=0" env "TEST_GO=1" bash
dev/release/verify-release-candidate.sh source 6.0.0 3
+```
+
+##### Ubuntu 20.04
+
+Possible steps run as root user. They should be modified for
+your setup appropriately.
+
+```console
+% apt-get update
+% apt-get install -y cmake wget curl libboost-all-dev jq unzip
+% apt-get install -y -q autoconf-archive gtk-doc-tools libgirepository1.0-dev
+% apt-get update -y -qq
+% apt-get install -y build-essential openjdk-8-jdk
+% wget
https://dlcdn.apache.org/maven/maven-3/3.8.3/binaries/apache-maven-3.8.3-bin.zip
+% unzip apache-maven-3.8.3-bin.zip
+% mkdir -p $HOME/java
+% mv apache-maven-3.8.3 $HOME/java
+% export PATH=$HOME/java/apache-maven-3.8.3/bin:$PATH
+% apt-get install -y curl g++ gcc autoconf automake bison libc6-dev libffi-dev
+% apt-get install -y libgdbm-dev libncurses5-dev libsqlite3-dev libtool
libyaml-dev
+% apt-get install -y make pkg-config sqlite3 zlib1g-dev libgmp-dev
+% apt-get install -y libreadline-dev libssl-dev
+% wget https://cache.ruby-lang.org/pub/ruby/3.0/ruby-3.0.2.tar.gz
+% tar -xvf ruby-3.0.2.tar.gz
+% cd ruby-3.0.2/
+% CC=gcc ./configure --prefix=$HOME/ruby
+% CC=gcc make
+% make install
+% cd ..
+% export PATH=$HOME/ruby/bin:$PATH
+% wget https://apt.llvm.org/llvm.sh
+% chmod +x llvm.sh
+% ./llvm.sh 10
+% apt-get install -y clang-format clang-tidy clang-tools clang clangd
libc++-dev
+% apt-get install -y libc++1 libc++abi-dev libc++abi1 libclang-dev libclang1
+% apt-get install -y liblldb-dev libllvm-ocaml-dev libomp-dev libomp5 lld lldb
+% apt-get install -y llvm-dev llvm-runtime llvm python-clang
+% apt-get install -y ninja-build python3-pip
+% curl -fsSL https://download.docker.com/linux/ubuntu/gpg | sudo gpg --dearmor
-o /usr/share/keyrings/docker-archive-keyring.gpg
+% echo "deb [arch=$(dpkg --print-architecture)
signed-by=/usr/share/keyrings/docker-archive-keyring.gpg]
https://download.docker.com/linux/ubuntu \
+% $(lsb_release -cs) stable" | sudo tee /etc/apt/sources.list.d/docker.list >
/dev/null
+% apt-get update
+% apt-get install -y docker-ce docker-ce-cli containerd.io
+% git clone https://github.com/apache/arrow
+% cd arrow/
+% bash dev/release/verify-release-candidate.sh source 6.0.0 3
+```
+
+### CentOS 8, Alma Linux 8, Rocky Linux 8
Review comment:
```suggestion
### AlmaLinux 8, Rocky Linux 8
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
