WilliamWhispell commented on a change in pull request #11359:
URL: https://github.com/apache/arrow/pull/11359#discussion_r738426911
##########
File path: go/arrow/array/record.go
##########
@@ -338,6 +348,53 @@ func (b *RecordBuilder) NewRecord() Record {
return NewRecord(b.schema, cols, rows)
}
+// UnmarshalJSON for record builder will read in a single object and add the
values
+// to each field in the recordbuilder, missing fields will get a null and
unexpected
+// keys will be ignored. If reading in an array of records as a single batch,
then use
+// a structbuilder and use RecordFromStruct.
+func (b *RecordBuilder) UnmarshalJSON(data []byte) error {
+ dec := json.NewDecoder(bytes.NewReader(data))
+ // should start with a '{'
+ t, err := dec.Token()
+ if err != nil {
+ return err
+ }
+
+ if delim, ok := t.(json.Delim); !ok || delim != '{' {
+ return fmt.Errorf("record should start with '{', not %s", t)
+ }
+
+ keylist := make(map[string]bool)
+ for dec.More() {
+ keyTok, err := dec.Token()
+ if err != nil {
+ return err
+ }
+
+ key := keyTok.(string)
Review comment:
any need to check cast is ok?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
