nealrichardson commented on a change in pull request #11539:
URL: https://github.com/apache/arrow/pull/11539#discussion_r738516014
##########
File path: r/tests/testthat/test-feather.R
##########
@@ -233,18 +233,18 @@ ft_file <-
test_path("golden-files/data-arrow_2.0.0_lz4.feather")
test_that("Error messages are shown when the compression algorithm lz4 is not
found", {
msg <- paste0(
- "NotImplemented: Support for codec 'lz4' not built\nIn order to read this
file, ",
+ ".*",
"you will need to reinstall arrow with additional features enabled.\nSet
one of ",
- "these environment variables before installing:\n\n *
LIBARROW_MINIMAL=false ",
- "(for all optional features, including 'lz4')\n * ARROW_WITH_LZ4=ON (for
just 'lz4')",
+ "these environment variables before installing:\n\n \\*
LIBARROW_MINIMAL=false ",
+ "\\(for all optional features, including 'lz4'\\)\n \\* ARROW_WITH_LZ4=ON
\\(for just 'lz4'\\)",
"\n\nSee https://arrow.apache.org/docs/r/articles/install.html for details"
)
if (codec_is_available("lz4")) {
d <- read_feather(ft_file)
expect_s3_class(d, "data.frame")
} else {
- expect_error(read_feather(ft_file), msg, fixed = TRUE)
+ expect_error(read_feather(ft_file), msg, fixed = FALSE)
Review comment:
FALSE is default
```suggestion
expect_error(read_feather(ft_file), msg)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
