jonkeane commented on a change in pull request #11567:
URL: https://github.com/apache/arrow/pull/11567#discussion_r738553416
##########
File path: docker-compose.yml
##########
@@ -1283,7 +1284,7 @@ services:
volumes: *debian-volumes
command: &js-command >
/bin/bash -c "
- /arrow/ci/scripts/js_build.sh /arrow &&
+ /arrow/ci/scripts/js_build.sh /arrow true &&
Review comment:
I don't think that we need this here as well as above — we can pick one
if I'm understanding correctly
##########
File path: docker-compose.yml
##########
@@ -1088,6 +1088,7 @@ services:
/bin/bash -c "
/arrow/ci/scripts/cpp_build.sh /arrow /build &&
/arrow/ci/scripts/python_build.sh /arrow /build &&
+ /arrow/ci/scripts/r_build.sh /arrow true &&
Review comment:
Something that might be confusing is that we [specify `install =
FALSE`](https://github.com/apache/arrow/blob/master/ci/scripts/r_build.sh#L30)
because pkgdown will (re)install the package automatically without that
argument — and since we _just_ installed it two lines above, we don't want to
reinstall all over again.
##########
File path: docker-compose.yml
##########
@@ -1088,6 +1088,7 @@ services:
/bin/bash -c "
/arrow/ci/scripts/cpp_build.sh /arrow /build &&
/arrow/ci/scripts/python_build.sh /arrow /build &&
+ /arrow/ci/scripts/r_build.sh /arrow true &&
Review comment:
And to answer the question more directly I believe we _would_ need to
have the package installed if we want to run the pkgdown commands to build the
docs site here: that process requires a working package to run our vignettes.
##########
File path: docker-compose.yml
##########
@@ -1088,6 +1088,7 @@ services:
/bin/bash -c "
/arrow/ci/scripts/cpp_build.sh /arrow /build &&
/arrow/ci/scripts/python_build.sh /arrow /build &&
+ /arrow/ci/scripts/r_build.sh /arrow true &&
Review comment:
I'll also note that we have a script that is run on each PR to check
that we're mapping articles correctly (this is one of the manual steps we have
to do and we found it helpful to fail this build if we don't:
https://github.com/apache/arrow/blob/master/.github/workflows/r.yml#L80-L81
https://github.com/apache/arrow/blob/master/ci/scripts/r_pkgdown_check.sh
Though I'm not at all opposed to also including a step that does the full
pkgdown build!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
