alamb commented on issue #1184: URL: https://github.com/apache/arrow-datafusion/issues/1184#issuecomment-954029887
> @alamb have you compared the two different proposals that @Dandandan and I put? > to have one untyped enum case Null > to have one typed enum case Null(DataType) and remove the Option wrapping for all other enum cases @Jimexist I have not fully worked through the implications of either approach. One thing I suspect will occur is that the code in GroupByHash (and elsewhere) really wants to know what "type" the ScalarValue is even if it is null -- because rust is strongly typed. A third option might be to leave the representation of `ScalarValue` as it is and instead return `DataType::Null` if it represents a null value. Another challenge is that there really is a difference between a `NullArray` and an `Int8Array` of all nulls (for example). And both are valid concepts 🤔 Thus I conclude that trying out an approach with some sort of technical spike sounds like a great idea to me 👍 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
