alamb commented on issue #1196:
URL: 
https://github.com/apache/arrow-datafusion/issues/1196#issuecomment-954111101


   > @alamb Hi, I'd like to have a try to fix this issue. In order to remove 
the all match arm, Sort and Wildcard need be implemented as well. Do you want 
to include those in the same pull request?
   
   @capkurmagati  I would suggest changing the catch all  `match` arm for 
`Sort` and `Wildcard` to return the internal error -- they should never need to 
get an auto alias. 
   
   The danger is that by having a `_` type match, when a new Expr variant is 
added the compiler doesn't flag this match as something in need of fix
   
   @xudong963 
   
   > FYI, I try it in Postgres.
   
   Indeed, both ways with and without an alias with Postgres:
   
   ```
   alamb=# select 1 between 5 and 10 as my_expr;
    my_expr 
   ---------
    f
   (1 row)
   
   alamb=# select 1 between 5 and 10;
    ?column? 
   ----------
    f
   (1 row)
   
   alamb=# 
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to