zeroshade commented on a change in pull request #11566:
URL: https://github.com/apache/arrow/pull/11566#discussion_r738752305
##########
File path: go/parquet/writer_properties.go
##########
@@ -18,7 +18,7 @@ package parquet
import (
"github.com/apache/arrow/go/arrow/memory"
Review comment:
if we are going to keep the arrow and parquet modules versioned
separately with their own go.mod files, then what would need to happen would be:
1. Create `go/arrow/vX.Y.Z` tag pointing at commit which contains `/vX` in
the arrow directory and its files. push it to github
2. add `/vX` suffix to `github.com/apache/arrow/go/arrow/` import statements
throughout the .go files of `go/parquet/` and run `go get -u
github.com/apache/arrow/go/[email protected]` so it updates the go.mod and the
go.sum files.
3. commit the modified .go files in the `parquet/` dirs and the modified
`go.mod` and `go.sum` to git
4. Create `go/parquet/vX.Y.Z` tag pointing at this new commit.
The only way to avoid the extra commit is if we lift the `go.mod` file up
one directory to make the modules get versioned together as separate packages
of a single module rather than two separate modules. Then we'd only need one
tag of `go/vX.Y.Z` for both arrow and parquet libraries, and users would import
using `github.com/apache/arrow/go/v6/arrow` instead of
`github.com/apache/arrow/go/arrow/v6`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
