rdettai commented on a change in pull request #1141:
URL: https://github.com/apache/arrow-datafusion/pull/1141#discussion_r739048453



##########
File path: datafusion/src/datasource/listing/table.rs
##########
@@ -51,9 +52,9 @@ pub struct ListingOptions {
     /// partitioning expected should be named "a" and "b":
     /// - If there is a third level of partitioning it will be ignored.
     /// - Files that don't follow this partitioning will be ignored.
-    /// Note that only `DataType::Utf8` is supported for the column type.
-    /// TODO implement case where partitions.len() > 0
-    pub partitions: Vec<String>,
+    /// Note that only `DEFAULT_PARTITION_COLUMN_DATATYPE` is currently
+    /// supported for the column type.

Review comment:
       Let's discuss this in the other 
https://github.com/apache/arrow-datafusion/pull/1141#discussion_r738738023




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to