alamb commented on a change in pull request #1199:
URL: https://github.com/apache/arrow-datafusion/pull/1199#discussion_r739438511
##########
File path: datafusion/src/scalar.rs
##########
@@ -37,58 +37,60 @@ use std::{convert::TryFrom, fmt, iter::repeat, sync::Arc};
/// This is the single-valued counter-part of arrow’s `Array`.
#[derive(Clone)]
pub enum ScalarValue {
+ /// null value, typed or untyped
+ Null(Box<DataType>),
Review comment:
What is the reason to use `Box<DataType>` here? Is to keep the size of
`ScalarValue` relatively small?
What would you think about using `Arc<DataType>` instead to avoid as much
copying?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
