Dandandan commented on a change in pull request #1206:
URL: https://github.com/apache/arrow-datafusion/pull/1206#discussion_r739650615



##########
File path: datafusion/src/avro_to_arrow/arrow_array_reader.rs
##########
@@ -112,6 +112,7 @@ impl<'a, R: Read> AvroArrowArrayReader<'a, R> {
             // reached end of file
             return Ok(None);
         }
+        let rows = rows.iter().collect::<Vec<&Vec<(String, Value)>>>();

Review comment:
       Can we reduce this to one iteration by doing something in the loop above 
(`self.reader.by_ref().take(batch_size).map(|value|...` )
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to