alamb commented on a change in pull request #884:
URL: https://github.com/apache/arrow-rs/pull/884#discussion_r739656832
##########
File path: arrow/src/compute/kernels/cast.rs
##########
@@ -946,10 +965,6 @@ pub fn cast_with_options(
}
}
}
-
- // null to primitive/flat types
Review comment:
I think this particular special case was added in
https://github.com/apache/arrow/pull/8484 by @nevi-me -- I don't think there
was any fundamental reason not to include other types, just that it wasn't
needed for the particular issue he was dealing with
##########
File path: arrow/src/compute/kernels/cast.rs
##########
@@ -3518,17 +3533,39 @@ mod tests {
}
#[test]
- fn test_cast_null_array_to_int32() {
- let array = Arc::new(NullArray::new(6)) as ArrayRef;
+ fn test_cast_null_array_from_and_to_others() {
+ macro_rules! typed_test {
+ ($ARR_TYPE:ident, $DATATYPE:ident, $TYPE:tt) => {{
Review comment:
👍
looks good
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
