matthewmturner commented on a change in pull request #1180:
URL: https://github.com/apache/arrow-datafusion/pull/1180#discussion_r739761924
##########
File path: datafusion/tests/sql.rs
##########
@@ -2102,6 +2116,8 @@ async fn equijoin_and_other_condition() -> Result<()> {
let sql =
"SELECT t1_id, t1_name, t2_name FROM t1 JOIN t2 ON t1_id = t2_id AND
t2_name >= 'y' ORDER BY t1_id";
let actual = execute(&mut ctx, sql).await;
+ // let a = execute_to_batches(&mut ctx, sql).await;
+ // println!("{}", pretty_format_batches(&a).unwrap());
Review comment:
i just caught up the tracking comment that is used for test porting:
`// --- End Test Porting ---`
Let me know when you think its enough updates on this batch / PR to merge
and ill clean up those helpers so it can be merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
