novemberkilo commented on pull request #849:
URL: https://github.com/apache/arrow-rs/pull/849#issuecomment-955647565


   @alamb @bjchambers I have made changes to the csv writer according to the 
proposal.
   
   While doing so, I have noticed what I think is a bug in the temporal 
utilities in the kernel. Essentially, variations relating to daylight savings 
are not recognised at the moment. I have a failing test on a branch 
[here](https://github.com/novemberkilo/arrow-rs/commit/473e2e4eb4f3b47aa7110d1a23444647b1109665).
 I came up across this issue during this work as and had to implement 
https://github.com/novemberkilo/arrow-rs/blob/master/arrow/src/compute/kernels/temporal.rs#L98-L110
 to correctly derive the offset for a timezone. 
   
   I figure I should fix this bug separately -- should I file an issue to 
describe it and then put up a fix against that? Thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to