pjmore commented on pull request #1208:
URL: https://github.com/apache/arrow-datafusion/pull/1208#issuecomment-955777738
It's pretty bikesheddy so feel free to ignore me but for symmetric matches,
like for or, I tend to prefer matching like
```
(Expr::Literal(ScalarValue::Boolean(lit)), col) |
(col, Expr::Literal(ScalarValue::Boolean(lit)))
if self.is_boolean_type(col) => {
match lit{
Some(true) => Expr::Literal(ScalarValue::Boolean(Some(true))),
_ => *col
}
}
```
Which lets there be a single implementation instead of having two nearly
identical branches.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
